Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

falco: allow multiple socket paths for containerd #655

Open
leogr opened this issue Apr 12, 2024 · 4 comments
Open

falco: allow multiple socket paths for containerd #655

leogr opened this issue Apr 12, 2024 · 4 comments
Assignees
Labels
area/falco-chart kind/feature New feature or request

Comments

@leogr
Copy link
Member

leogr commented Apr 12, 2024

Motivation

We already support multiple containerd socket paths in Falco 👇
https://github.com/falcosecurity/libs/blob/34371e18cafa429107cf5d600bad5fd0c44718ab/userspace/libsinsp/container_engine/cri.cpp#L64-L68

This is not currently supported by the Falco chart.

This would particularly enable k3s by default but also allow users to add multiple paths in case their use case requires that.

Feature

Make the containerd.socket accept an array of paths. For example:

containerd:
# -- Enable ContainerD support.
enabled: true
# -- The path of the ContainerD socket.
socket: /run/containerd/containerd.sock

👇

 containerd: 
   # -- Enable ContainerD support. 
   enabled: true 
   # -- The paths to look for a ContainerD socket. The first match will be used.
   socket: [/run/containerd/containerd.sock, /run/k3s/containerd/containerd.sock]

Alternatives

The alternative would be to add a config node for each specific case (e.g., k3s). However, this is overkill and will not allow flexibility.

Additional context

@leogr leogr added kind/feature New feature or request area/falco-chart labels Apr 12, 2024
@poiana
Copy link
Contributor

poiana commented Jul 11, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@leogr
Copy link
Member Author

leogr commented Jul 18, 2024

/remove-lifecycle stale

@leogr
Copy link
Member Author

leogr commented Jul 18, 2024

Related falcosecurity/falco#3266

@leogr
Copy link
Member Author

leogr commented Aug 28, 2024

This likely needs to be addressed in 0.39, since falcosecurity/falco#3266 has been merged.

/assign @alacuku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/falco-chart kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants