-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recovery key screen during sign-in in EX shows unexpected "Create a new recovery key" option #2521
Comments
Talked this over some more with Patrick starting here https://matrix.to/#/!kCCQTCfnABLKGGvQjo:matrix.org/$my1fMW-QsNxYJOuJcKnVpFft_fWFXv0kdjzuUxR7nQM?via=matrix.org&via=element.io&via=one.ems.host We agree that this reset flow still makes sense for the "recovery out of sync" situation but that the copy is misleading. What we really want is to reuse the same as the identity verification screen i.e. replace |
Kamino cloned this issue to element-hq/element-x-android |
To create a new recovery key, the user as to go back and click on "Can't confirm", I do not think this is a good idea to add another entry point to reset on this screen. We previously had instruction to reset the key using another client but it has been remove in this PR: element-hq/element-x-android#3355 |
Exactly. That's why I've created this ticket. Android apparently already behaves correctly. Thanks for checking! |
There is another case where the user has successfully set up the app but some of the (crypto) secrets are missing. In this case the user will see a banner like this In this case there is no way to get to the "Confirm your identity" screen that has "Can't confirm". For this reason we need an entry point to identity reset here. I suggest to call it "Doesn't work?" since this can cover multiple cases
In all the above cases the user has to reset. So, all in all
|
Since this is already done in Android, I created a ticket for iOS: element-hq/element-x-ios#3357 cc @stefanceriu .
I will sync with @americanrefugee on the exact design of it. One thing is to have the button there so in principle user has the ability to reset. A totally different thing is to actually make it clear for the user why is it there and if/why they need to do it, etc. @bmarty @stefanceriu - are there any technical limitations/nuances for distinguishing if the recovery key entry screen pops up as part of the nominal device verification flow or during this special flow when user needs to "confirm" the recovery key. |
not as far as I'm aware, it should be pretty straight forwad |
Yes, same, there should not be any problem to distinguish cases. |
We had a quick session with Aaron - he suggested that instead of adding any extra buttons to the "enter recovery key" screen, we would add the "Can't confirm" button (title TBC) right into the initial banner. I like this approach much more, as it is consistent with the nominal device verification flow and we do not have multiple different versions of the same screen. Now, the major challenge is that it is still very hard for user to know when they need to press the "Can't confirm" button and do the reset, because:
@pmaier1 Do you know answers to the questions above or I should take this up with the Crypto team? I think if we're just going to rename the button something like "Can't confirm or did not work", then I do no think it makes any difference for the user - they are just as confused and would not know if reset is the right thing to do or not. |
At least on EXI (tested with 1.7.5), the key reset flow shows an unexpected "Create a new recovery key" option. This option doesn't give you the means to create a new recovery key (which isn't even possible at this point). Instead it just starts the regular key reset flow which is misleading and a duplication of the "Can't confirm" on the previous screen.
All in all, I think this is a leftover from previous designs and should be removed. Please check for Android as well.
@mxandreas @manuroe @stefanceriu @bmarty
The text was updated successfully, but these errors were encountered: