[SSSS] User password is asked multiple times then the app crashes when trying to reset the recovery key.

[yostyle]

Steps to reproduce

case 1:

1. Go to Settings > Security & Privacy
2. In Secure Backup section tap on "Set up on this device".
3. Choose "Reset everything"
4. Tap on "Proceed to resest"
5. Select "Use a Security Key"
6. Enter your password

Screen_recording_20240708_124924.mp4

case 2:

1. secure_backup_required is enabled in wellknown configuration
2. Log in to Element Android
3. Choose "Reset everything"
4. Tap on "Proceed to resest"
5. Select "Use a Security Key"
6. Enter your password

Screen_recording_20240704_191824.mp4

Outcome

What did you expect?

Get a recovery key

What happened instead?

User password is asked multiple times and the app crashes.

bootstrapTask invoked from startInitializeFlow method is called multiple times :

• element-android/vector/src/main/java/im/vector/app/features/crypto/recover/BootstrapSharedViewModel.kt

  Line 225 in e3a8781

  startInitializeFlow(state)

• element-android/vector/src/main/java/im/vector/app/features/crypto/recover/BootstrapSharedViewModel.kt

  Line 297 in e3a8781

  startInitializeFlow(it)

Your phone model

Pixel 8 Pro

Operating system version

Android 14

Application version and app store

Element 1.6.16

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

No

[yostyle]

@bmarty @BillCarsonFr We need to understand why startInitializeFlow method may be called multiple times ? If not what is the right way to fix that ?

[yostyle]

What do you think about those following quick fixes ?

https://github.com/tchapgouv/tchap-android/blob/216762a06bd7c31fa2c9ea7417006863426bed1f/vector/src/main/java/im/vector/app/features/crypto/recover/BootstrapSharedViewModel.kt#L231

https://github.com/tchapgouv/tchap-android/blob/216762a06bd7c31fa2c9ea7417006863426bed1f/vector/src/main/java/im/vector/app/features/crypto/recover/BootstrapSharedViewModel.kt#L218

[BillCarsonFr]

@bmarty @BillCarsonFr We need to understand why startInitializeFlow method may be called multiple times ? If not what is the right way to fix that ?

Hello @yostyle , I suspect that what you are seeing is a regression due to #8786

When UIA kicks in, the state is set to ReAuth step that will then show the ReAuthFragment that then does an auto submit (calling again startInitializeFlow)

element-android/vector/src/main/java/im/vector/app/features/crypto/recover/BootstrapReAuthFragment.kt

Lines 48 to 52 in b0158f1

	val viewModel = ViewModelProvider(this).get(BootstrapReAuthViewModel::class.java)
	if (!viewModel.isFirstSubmitDone) {
	viewModel.isFirstSubmitDone = true
	submit()
	}