Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GrpcClient constructor should add http2ClearTextUpgrade(false) to passed HttpOptions #27

Open
doctorpangloss opened this issue Dec 27, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@doctorpangloss
Copy link

Version

4.3.7

Context

The GrpcClient constructors allow you to pass in custom HttpOptions.

Because httpOptions.setHttp2ClearTextUpgrade(false) must be set, the constructor should do it for you, like the default constructor does.

Steps to reproduce

  1. Create a client with GrpcClient.client(vertx, new HttpClientOptions()).
  2. Observe the server replies with an unexpected HTTP/1.1 protocol error.
  3. Observe GrpcClient.client(vertx, new HttpClientOptions().setHttp2ClearTextUpgrade(false)) resolves the issue.

This is a known issue. It is never valid to have this set to true (or the default) on a GrpcClient.

@doctorpangloss doctorpangloss added the bug Something isn't working label Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant