-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made the examples self contained #5
Conversation
…n loaded fresh; This should also make the first load of the antd examples faster as it doesn't need to load every example when just one gets visited
… defining date-picker in each of them
…er when loaded fresh; This should also make the first load of the Formik+MUI examples faster as it doesn't need to load every example when just one gets visited
Hi @leroydev , thank you very much for deep dive into code and propose optimization! However, adapter is designed to be a global config. Just like you need to config global providers for redux, some UI libs, etc. So using nice form consists of two parts, one for config and the other is real usage. |
Hi @supnate, thanks for taking the time to review quickly! If not, I do feel that including the definition of the custom datepicker in each example does add value. And the lazy loading should make the docs faster to load so might also be an improvement you want to consider. Let me know which parts you want in what form and I'll make adjustments 🙂 |
Thanks @leroydev .
|
Closed in favor of #6 |
Closes #4.
Also makes all the examples lazy loaded. This should speed up first load speed of the examples website but should be tested whether this works properly in a production build too. Locally for me with a production build served with http-server it did work.