From 18e917d4e8c2eef1b7a5ea57c057bca78a1c95b9 Mon Sep 17 00:00:00 2001
From: yuyi <yuyi@fnal.gov>
Date: Fri, 24 Sep 2021 13:46:02 -0500
Subject: [PATCH] fixed counting for tracer made.

---
 stompserver/fwjrTracer.go |  2 ++
 stompserver/traceMaker.go | 20 ++++++++++----------
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/stompserver/fwjrTracer.go b/stompserver/fwjrTracer.go
index 0a96a43..d62d662 100644
--- a/stompserver/fwjrTracer.go
+++ b/stompserver/fwjrTracer.go
@@ -191,6 +191,8 @@ func FWJRtrace(msg *stomp.Message) ([]string, error) {
 					log.Println("\n", string(data))
 					log.Println("******** Done Rucio trace record *************")
 				}
+				// a good trace made
+				Traces.Inc()
 				// send data to Stomp endpoint
 				if Config.EndpointProducer != "" {
 					err := stompMgr.Send(data, stomp.SendOpt.Header("appversion", "fwjrAMQ"))
diff --git a/stompserver/traceMaker.go b/stompserver/traceMaker.go
index f0505c7..90bef0f 100644
--- a/stompserver/traceMaker.go
+++ b/stompserver/traceMaker.go
@@ -199,12 +199,21 @@ func traceSender(msg *stomp.Message, topic string) ([]string, error) {
 				log.Printf("Unable to marshal back to JSON string, error: %v \n", err)
 			}
 			dids = append(dids, fmt.Sprintf("%v", trc.DID))
+			continue
 		}
 		if Config.Verbose > 2 {
 			log.Printf("********* Rucio trace record from %s ***************\n", topic)
 			log.Println("\n" + string(data))
 			log.Printf("\n******** Done Rucio trace record from %s *************\n", topic)
 		}
+		// a good trace made
+		if topic == "xrtd" {
+			Traces_xrtd.Inc()
+		} else if topic == "swpop" {
+			Traces_swpop.Inc()
+		} else {
+			log.Fatalf(" Topic %s is not supported. \n", topic)
+		}
 		// send data to Stomp endpoint
 		if Config.EndpointProducer != "" {
 			err := stompMgr.Send(data, stomp.SendOpt.Header("appversion", "xrootdAMQ"))
@@ -275,18 +284,9 @@ func traceServer(topic string) {
 				dids, err = traceSender(msg, topic)
 			}
 			if err == nil {
-				if topic == "fwjr" {
-					Traces.Inc()
-				} else if topic == "xrtd" {
-					Traces_xrtd.Inc()
-				} else if topic == "swpop" {
-					Traces_swpop.Inc()
-				} else {
-					log.Fatalf(" Topic %s is not supported. \n", topic)
-				}
 				atomic.AddUint64(&tc, 1)
 				if Config.Verbose > 1 {
-					log.Println("The number of traces processed in 1000 group: ", atomic.LoadUint64(&tc))
+					log.Println("The number of messages processed in 1000 group: ", atomic.LoadUint64(&tc))
 				}
 			}