Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/basic: check unused deps on 'check' job #2941

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented Sep 30, 2024

this adds a step bnjbvr/cargo-machete@main to check if there are unused dependencies in the project.

@jprendes jprendes added the dependencies Pull requests that update a dependency file label Sep 30, 2024
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jprendes
Copy link
Contributor

@Mossaka , could you add a sign-off to the commit?
Thanks!

this adds a step bnjbvr/cargo-machete@main to check if there are
unused dependencies in the project.

Signed-off-by: jiaxiao zhou <[email protected]>
Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@YJDoc2 YJDoc2 merged commit c74b67b into containers:main Oct 1, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
@Mossaka Mossaka deleted the add-machete-to-ci branch October 1, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants