Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Quarkus 3.0 #204

Open
apupier opened this issue May 10, 2023 · 0 comments · May be fixed by #206
Open

Migrate to Quarkus 3.0 #204

apupier opened this issue May 10, 2023 · 0 comments · May be fixed by #206
Assignees

Comments

@apupier
Copy link
Member

apupier commented May 10, 2023

@apupier apupier self-assigned this May 10, 2023
apupier added a commit to apupier/compas-scl-validator that referenced this issue May 26, 2023
the main change is migrating from JavaEE to JakartaEE.

- update Quarkus bom from io.quarkus:quarkus-universe-bom to
io.quarkus.platform:quarkus-bom as it was deprecated since Quarkus 2.1
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.1#quarkus-universe-bom-is-deprecated
(and it is required to use the Quarkus migration tool)
- deactivated tests CompasOclFileCollectorTest and
SclRiseClipseValidatorTest which are failign locally so that I can build
locally the whole project and have the Quarkus migration tool working
- launched quarkus `quarkus update --stream=3.0` as mentioned in
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#automatic-update-tool
which dealt with a fair part of the migration. Then it remained few
little tasks.

fix com-pas#204

Currently build failure:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile
(default-compile) on project app: Compilation failure: Compilation
failure:
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/encoder/SclValidateWsResponseEncoder.java:[10,8]
cannot access javax.websocket.Encoder
[ERROR]   class file for javax.websocket.Encoder not found
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/decoder/SclValidateWsResponseDecoder.java:[10,8]
cannot access javax.websocket.Decoder
[ERROR]   class file for javax.websocket.Decoder not found
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/SclValidatorServerEndpoint.java:[30,48]
incompatible types:
java.lang.Class<org.lfenergy.compas.scl.validator.websocket.v1.decoder.SclValidateWsRequestDecoder>
cannot be converted to java.lang.Class<? extends
jakarta.websocket.Decoder>
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/SclValidatorServerEndpoint.java:[31,49]
incompatible types:
java.lang.Class<org.lfenergy.compas.scl.validator.websocket.v1.encoder.SclValidateWsResponseEncoder>
cannot be converted to java.lang.Class<? extends
jakarta.websocket.Encoder>
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/SclValidatorServerEndpoint.java:[31,77]
incompatible types:
java.lang.Class<org.lfenergy.compas.core.websocket.ErrorResponseEncoder>
cannot be converted to java.lang.Class<? extends
jakarta.websocket.Encoder>
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/SclValidatorServerEndpoint.java:[59,9]
cannot access javax.websocket.Session
[ERROR]   class file for javax.websocket.Session not found
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/encoder/SclValidateWsResponseEncoder.java:[11,5]
method does not override or implement a method from a supertype
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/decoder/SclValidateWsResponseDecoder.java:[11,5]
method does not override or implement a method from a supertype
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/decoder/SclValidateWsResponseDecoder.java:[16,5]
method does not override or implement a method from a supertype
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/decoder/SclValidateWsRequestDecoder.java:[11,5]
method does not override or implement a method from a supertype
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/decoder/SclValidateWsRequestDecoder.java:[16,5]
method does not override or implement a method from a supertype
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/event/SclValidatorEventHandler.java:[29,81]
incompatible types: jakarta.websocket.Session cannot be converted to
javax.websocket.Session
[ERROR] /home/apupier/git/compas-scl-validator/app/src/main/java/org/lfenergy/compas/scl/validator/websocket/v1/encoder/SclValidateWsRequestEncoder.java:[11,5]
method does not override or implement a method from a supertype
```

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier linked a pull request May 26, 2023 that will close this issue
apupier added a commit to apupier/compas-scl-validator that referenced this issue May 26, 2023
the main change is migrating from JavaEE to JakartaEE.

- update Quarkus bom from io.quarkus:quarkus-universe-bom to
io.quarkus.platform:quarkus-bom as it was deprecated since Quarkus 2.1
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-2.1#quarkus-universe-bom-is-deprecated
(and it is required to use the Quarkus migration tool)
- deactivated tests CompasOclFileCollectorTest and
SclRiseClipseValidatorTest which are failing locally so that I can build
locally the whole project and have the Quarkus migration tool working
- launched quarkus `quarkus update --stream=3.0` as mentioned in
https://github.com/quarkusio/quarkus/wiki/Migration-Guide-3.0#automatic-update-tool
which dealt with a fair part of the migration. Then it remained few
little tasks.

fix com-pas#204

TO  UPDATE THE version of compas.core when a release is available

Signed-off-by: Aurélien Pupier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant