Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a more representative Exception when Auto alignment failes #266

Open
pascalwilbrink opened this issue Dec 5, 2023 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@pascalwilbrink
Copy link
Member

The SubstationGraphBuilder requires 2 (or 3) TransformerWindings to be present.
All these TransformerWindings require a Terminal section (+ ConnectivityNode in that Terminal Section).
When either the Terminal element, or the ConnectivityNode element is not present in the SCL file, a default exception message gets thrown (For Terminal: ArrayIndexOutOfBounds, for ConnectivityNode: NullPointer).
We should add assertions before trying to create the FeederNode:

https://github.com/com-pas/compas-scl-auto-alignment/blob/develop/service/src/main/java/org/lfenergy/compas/scl/auto/alignment/builder/SubstationGraphBuilder.java#L90

@pascalwilbrink pascalwilbrink added the enhancement New feature or request label Dec 5, 2023
@JakobVogelsang
Copy link

This above assumption does not hold with three winding transformers, at least not when the third winding is not connected to anything else than itself Compensating winding.

Unfortunately, it is hard to know which one of the three is one.

I therefore would propose a slightly other behavior:
We expect to there be at least one connected transformer winding. Connected means there is a Terminal child element pointing to a valid ConnectivityNode.

It would be consistent with what we expect from the elements ConductingEquipment here one connection is enough as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants