Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve health check timeout documentation #470

Open
beyhan opened this issue Jan 9, 2023 · 6 comments
Open

Improve health check timeout documentation #470

beyhan opened this issue Jan 9, 2023 · 6 comments

Comments

@beyhan
Copy link
Member

beyhan commented Jan 9, 2023

Improve the health checks timeout section with more specific information about how to set it. At the moment the CF CLI doesn't support health check timeout configuration as described in this issue and users get confused with the --invocation-timeout option supported by the CF CLI. I'm suggesting to make it more clear how the timeout could be configured via CF CLI and CF APIs.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@anita-flegg
Copy link
Contributor

@Gerg , do you have any suggestions for how to do this correctly? Thanks :)

@beyhan
Copy link
Member Author

beyhan commented Mar 14, 2023

My suggestion is:
Is it by intention that cf set-health-check shouldn't support the timeout configuration because it is relevant when pushing an app? If yes, we can just put a note that it should be configured during push with cf push -t or in the manifest and set-health-check doesn't support it.

@anita-flegg
Copy link
Contributor

@beyhan , have you had any update on this?

@beyhan
Copy link
Member Author

beyhan commented Dec 4, 2023

Hi @anita-flegg,

I didn't get any feedback on the CLI issue but I will create in the next days a pr for the docs to add more details about this at least.

@anita-flegg
Copy link
Contributor

Thanks, @beyhan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants