Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to check commits for a brand new branch on GitLab #101

Open
christophebedard opened this issue Mar 3, 2021 · 0 comments
Open

Fails to check commits for a brand new branch on GitLab #101

christophebedard opened this issue Mar 3, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@christophebedard
Copy link
Owner

christophebedard commented Mar 3, 2021 •
edited
Loading

See here: #94 (comment)

For example, in the comment linked above, I created a new project and pushed a first commit. This created the default branch (master) at the same time. $CI_COMMIT_BEFORE_SHA is then 0000000....

With #94, dco-check disregards situations like that as if there were no new commits. This should be fixed.
@christophebedard christophebedard added the bug Something isn't working label Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@christophebedard