Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version identifier as metadata field #19

Open
devidw opened this issue Sep 8, 2022 · 2 comments
Open

version identifier as metadata field #19

devidw opened this issue Sep 8, 2022 · 2 comments

Comments

@devidw
Copy link

devidw commented Sep 8, 2022

! version: 1.0.0

Could be a helpful addition to the default goggle metadata fields.

Used for what?

  • To track and identify different versions of a goggle
  • Perhaps Brave Search could regularly check submitted goggle URLs, if a version change is identified, the goggle is automatically refreshed without the need of resubmitting it on every update by the user
@remusao
Copy link
Collaborator

remusao commented Sep 8, 2022

Hi @devidw,

Thanks for the great feedback. As far as I understand, the version could be an indication to the users of a Goggle that they are using a newer version? This is implicitly done using a "last fetched" timestamp as well as a hash of the content (internally).

Regarding the second idea of re-fetching, it's something that we have considered at some point but currently did not implement, preferring the simpler alternative of having explicit upload from maintainers (this can be useful if you wanna push a few changes to your hosted Goggle, but do not necessarily feel comfortable pushing it to all users via Brave Search).

I hope that helps,

@devidw
Copy link
Author

devidw commented Sep 8, 2022

Hey @remusao

Thanks for your comment

As far as I understand, the version could be an indication to the users of a Goggle that they are using a newer version?

For example, yes.

Or, if there are breaking changes inside a goggle, goggle subscribers can clearly decide to go with a newer version or not.

But taking into account that goggles are hosted on completely version controlled repos, perhaps that's obsolete, since users would be able to submit or subscribe to any other version from any URL in the GIT history.

Okay, got it, cross that out. :D


this can be useful if you wanna push a few changes to your hosted Goggle, but do not necessarily feel comfortable pushing it to all users via Brave Search

Yes, that's a good point.

The way I was thinking about it was that the search engine would only pull the changes when it identifies a change in the version meta data field.

Therefore, committing updates to the host without bumping the version number should do nothing.

The search engine would only update its reference when there is a change to the currently stored/referenced one.

This would assume that the search engine would store the version number along with the URL in its databases.

@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
@brave brave deleted a comment from Aszezo Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants