Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starlarkify sh_library #23660

Closed
wants to merge 1 commit into from
Closed

Starlarkify sh_library #23660

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 18, 2024

Work towards #23658

RELNOTES[inc]: Only sh_library targets are permitted in the deps of sh_library rules. Other rules were previously permitted with a warning, but now need to be moved to srcs or data.

@fmeum fmeum force-pushed the sh-library branch 4 times, most recently from 8ee2ae3 to e24e487 Compare September 18, 2024 18:36
@fmeum fmeum requested a review from comius September 19, 2024 06:44
@fmeum fmeum marked this pull request as ready for review September 19, 2024 06:44
@fmeum fmeum requested a review from a team as a code owner September 19, 2024 06:44
@fmeum fmeum requested review from aranguyen and removed request for a team September 19, 2024 06:44
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Sep 19, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 19, 2024

@comius If you are happy with this, I can also take care of sh_binary.

@comius
Copy link
Contributor

comius commented Sep 23, 2024

Nice thanks! Go ahead with sh_binary.

Internal rules are slightly different, @c-mita is working of them. But it shouldn't be a problem to eventually share the code.

If you haven't noticed, we also have a repo ready https://github.com/bazelbuild/rules_sh. This is where the code is eventually suppose to land...

@comius comius added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 23, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 23, 2024

@aherrmann FYI about the name conflict with https://registry.bazel.build/modules/rules_sh

@copybara-service copybara-service bot closed this in 125e6e8 Oct 1, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 1, 2024
@fmeum fmeum deleted the sh-library branch October 1, 2024 09:28
@aherrmann
Copy link
Contributor

@fmeum thanks for the ping!

To add some context on the naming of https://registry.bazel.build/modules/rules_sh:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants