feat: support only updating existing BUILD files #1921
Conversation
| @@ -73,7 +86,7 @@ func (*Configurer) RegisterFlags(fs *flag.FlagSet, cmd string, c *config.Config) | |||
| func (*Configurer) CheckFlags(fs *flag.FlagSet, c *config.Config) error { return nil } | |||
|
|
|||
| func (*Configurer) KnownDirectives() []string { | |||
| return []string{"exclude", "follow", "ignore"} | |||
| return []string{"generation_mode", "exclude", "follow", "ignore"} | |||
There was a problem hiding this comment.
This is the directive named used by the Aspect plugins today. I think we need something better here that doesn't include the word "mode" which already has a meaning within gazelle.
Ideas?
There was a problem hiding this comment.
build_file_action?
create_build_files yes/no?
There was a problem hiding this comment.
I am going to try to this patch at Airtable. I am thinking instead of manually specifying generation_mode to isntead do something like (pseudocode) collectionOnly := f == nil !any(file.endswith('.go') for file in ents), since we have go code spread throughout the tree
There was a problem hiding this comment.
I think different repos will have different preferences and we can't really make any assumptions based on which files exist.
jbedard
force-pushed
the
1832-gen-mode
branch
from
c4a69da
to
bcf35e8
Compare
jbedard
force-pushed
the
1832-gen-mode
branch
3 times, most recently
from
d1e111d
to
496ec9e
Compare
jbedard
force-pushed
the
1832-gen-mode
branch
from
496ec9e
to
fb71250
Compare
Close #1832
What type of PR is this?
Feature
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Add an option to enable only updating existing BUILDs and not creating any new ones.
I think this is common among extension authors, normally implemented with a quick-exit within
Configureif the*rule.Fileisnil. However all the subdirs then need to be manually traversed to find files in subdirectories with no BUILD.I've always maintained a patch similar to this PR to avoid plugins having to do manual fs operations.
Which issues(s) does this PR fix?
Fixes #1832
Other notes for review