Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: npm_translate_lock bins should be available when running custom_postinstalls #1264

Open
twheys opened this issue Sep 11, 2023 · 0 comments
Labels
enhancement New feature or request untriaged Requires traige

Comments

@twheys
Copy link

twheys commented Sep 11, 2023

What is the current behavior?

bins are available in the custom_postinstall currently IFF the library that the custom_postinstall is being ran for depends on the other package where the binary is available. I think this should be changed such that if a binary is set in the bins attribute, it is available during the custom_postinstall regardless of module dependencies.

Describe the feature

During the execution of custom_postinstalls, the node binaries defined in the bins attribute of npm_translate_lock should be defined so that they can be referenced directly.

example:

npm_translate_lock(
    name = "npm",
    bins = {
        "@angular/compiler-cli": {"ngcc": "./bundles/ngcc/main-ngcc.js"},
    },
    custom_postinstalls = {
        "@angular/core": "ngcc",
    },
    ...
)
@twheys twheys added the enhancement New feature or request label Sep 11, 2023
@github-actions github-actions bot added the untriaged Requires traige label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged Requires traige
Projects
Status: No status
Development

No branches or pull requests

1 participant