Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Add support for py_library dependencies in aws_py_lambda rule #51

Open
wevonosky opened this issue Feb 16, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@wevonosky
Copy link

What is the current behavior?

Currently py_library dependencies are seemingly ignored by the implementation of the _py_lambda_tar rule. This presents problems for organizations which maintain internal libraries that they want their lambdas to be able to depend on.

For example:

aws_py_lambda(
    name = "image",
    entry_point = "lambda_function.py",
    deps = [requirement("requests"), "//path/to/internal/lib"],
)

oci_tarball(
    name = "tarball",
    image = ":image",
    repo_tags = ["aws_lambda_hello_world:latest"],
    visibility = [":__subpackages__"],
)

results in no trace of the internal lib in the image that gets created when calling bazel run :tarball.

Describe the feature

py_library dependencies should be included when creating a aws_py_lambda image.

@wevonosky wevonosky added the enhancement New feature or request label Feb 16, 2024
@wevonosky wevonosky changed the title [FR]: Add support for py_library dependencies in aws_py_lambda rule [FR]: Add support for py_library dependencies in aws_py_lambda rule Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant