Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIOWritePCAPHandler crashes if used with UNIX Domain Sockets #92

Open
weissi opened this issue Jun 12, 2020 · 0 comments
Open

NIOWritePCAPHandler crashes if used with UNIX Domain Sockets #92

weissi opened this issue Jun 12, 2020 · 0 comments
Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.

Comments

@weissi
Copy link
Member

weissi commented Jun 12, 2020

When using NIOWritePCAPHandler with UNIX Domain Sockets, it crashes.

That's because UNIX Domain Sockets don't have IP addresses and ports.

If the user passes a fakeLocal/RemoteAddress, everything's good but we should just have a default one in case the user doesn't.
@weissi weissi added good first issue Good for newcomers kind/bug Feature doesn't work as expected. labels Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/bug Feature doesn't work as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weissi