Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create NDK variant of ultrahdr sample #1052

Open
DanAlbert opened this issue May 14, 2024 · 0 comments
Open

create NDK variant of ultrahdr sample #1052

DanAlbert opened this issue May 14, 2024 · 0 comments

Comments

@DanAlbert
Copy link
Member

https://github.com/android/platform-samples/blob/ce4c345033e42a354a87fd5f7fc73f5518c32499/samples/graphics/ultrahdr/src/main/java/com/example/platform/graphics/ultrahdr/opengl/UltraHDRWithOpenGL.kt would be a good thing to create an NDK equivalent of. It does what the old display-p3 sample did, but does it right, and also does HDR.

DanAlbert added a commit to DanAlbert/ndk-samples that referenced this issue May 14, 2024
This teaches you how to do things you should not do. It shouldn't be
transforming the color space on the CPU at load time, it should be doing
it in a shader.

android#1052 is what we should
replace this with, but this is doing more harm than good, so just delete
it for now.
DanAlbert added a commit that referenced this issue May 14, 2024
This teaches you how to do things you should not do. It shouldn't be
transforming the color space on the CPU at load time, it should be doing
it in a shader.

#1052 is what we should
replace this with, but this is doing more harm than good, so just delete
it for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant