Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ament_vendor() does not install vendor project to correct path #475

Open
felixf4xu opened this issue Jul 9, 2023 · 1 comment
Open

ament_vendor() does not install vendor project to correct path #475

felixf4xu opened this issue Jul 9, 2023 · 1 comment
Assignees

Comments

@felixf4xu
Copy link

felixf4xu commented Jul 9, 2023

Hi,

I'm building ros2/rosbag2/zstd_vendor and the cmake file is like:

ament_vendor(zstd_vendor
  SATISFIED ${zstd_FOUND}
  VCS_URL https://github.com/facebook/zstd.git
  VCS_VERSION v1.4.8
  SOURCE_SUBDIR build/cmake
  CMAKE_ARGS
    -DZSTD_BUILD_STATIC:BOOL=OFF
    -DZSTD_BUILD_SHARED:BOOL=ON
    -DZSTD_BUILD_PROGRAMS:BOOL=OFF
)

but the current result is that bin/include/lib are installed at C:\ros\rolling\install\opt\zstd_vendor
image
but by colcon build --merge-install, I think those 3 sub folders should be installed to C:\ros\rolling\install.

@felixf4xu
Copy link
Author

oh, to fix the issue, I should change

install(
      DIRECTORY "${INSTALL_DIR}/"
      DESTINATION "opt/${PROJECT_NAME}"
      USE_SOURCE_PERMISSIONS
    )

to

install(
      DIRECTORY "${INSTALL_DIR}/"
      DESTINATION "${CMAKE_INSTALL_PREFIX}"
      USE_SOURCE_PERMISSIONS
    )

@cottsay cottsay self-assigned this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants