From d467684ecedfd3ca01e6f0765f191e62a38fb5c5 Mon Sep 17 00:00:00 2001 From: Aki Hamano Date: Tue, 1 Oct 2024 11:01:52 +0900 Subject: [PATCH] Fix: Shadow/Font size preset panel crashes the editor --- .../src/components/global-styles/font-sizes/font-size.js | 4 ++++ .../src/components/global-styles/shadows-edit-panel.js | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/packages/edit-site/src/components/global-styles/font-sizes/font-size.js b/packages/edit-site/src/components/global-styles/font-sizes/font-size.js index 25ff6812d583c..e32a43def49ae 100644 --- a/packages/edit-site/src/components/global-styles/font-sizes/font-size.js +++ b/packages/edit-site/src/components/global-styles/font-sizes/font-size.js @@ -46,6 +46,10 @@ function FontSize() { const [ globalFluid ] = useGlobalSetting( 'typography.fluid' ); + if ( ! origin || ! slug ) { + return null; + } + // Get the font sizes from the origin, default to empty array. const sizes = fontSizes[ origin ] ?? []; diff --git a/packages/edit-site/src/components/global-styles/shadows-edit-panel.js b/packages/edit-site/src/components/global-styles/shadows-edit-panel.js index ec1dd1a900c3b..8bd4810a80650 100644 --- a/packages/edit-site/src/components/global-styles/shadows-edit-panel.js +++ b/packages/edit-site/src/components/global-styles/shadows-edit-panel.js @@ -96,6 +96,10 @@ export default function ShadowsEditPanel() { const [ isRenameModalVisible, setIsRenameModalVisible ] = useState( false ); const [ shadowName, setShadowName ] = useState( selectedShadow.name ); + if ( ! category || ! slug ) { + return null; + } + const onShadowChange = ( shadow ) => { setSelectedShadow( { ...selectedShadow, shadow } ); const updatedShadows = shadows.map( ( s ) =>