Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): drop the slices with non-supported variables #25

Open
gabrieleAngius opened this issue Jun 27, 2023 · 0 comments
Open

feat(core): drop the slices with non-supported variables #25

gabrieleAngius opened this issue Jun 27, 2023 · 0 comments
Assignees
@gabrieleAngius

Comments

@gabrieleAngius
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Figma recented introduced variables, and looks like it's exactly what we need to create/maintain design tokens. Unfortunately, not all slices are currently supported: border radius, spacings (paddings, item spacings), colors e sizes (width, height, maxWidth, maxHeight). So we need to drop (for the moment) all non-supported features, since Figma will introduce them later.

Additional context
Here more info about the current and upcoming Figma features: beta features
This was referenced Jun 27, 2023
Closed
Closed
@gabrieleAngius gabrieleAngius self-assigned this Jun 27, 2023
gabrieleAngius added a commit that referenced this issue Jun 27, 2023
@gabrieleAngius
feat(core): drop border widths slice
87d0485 
dropping border width slice and remove all box-related logic due to upcoming changes related to
variables

wip #25
@gabrieleAngius gabrieleAngius mentioned this issue Jun 27, 2023
Merged
11 tasks
gabrieleAngius added a commit that referenced this issue Jun 30, 2023
@gabrieleAngius
feat(core): drop border widths slice (#26)
243d05f 
# Proposed changes

dropping border width slice and remove all box-related logic due to
upcoming changes related to variables

wip #25

## Types of changes

- [x] ✨ New feature (non-breaking change which adds functionality or
enhancements)
- [ ] 🐛 Bugfix (non-breaking change which fixes an issue)
- [ ] 💥 Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] ✅ Tests (added tests for an existing feature)
- [ ] 📚 Chore / Documentation Update (if none of the other choices
apply)
- [ ] 🙌 Other (please, write a clear and concise description of the
proposal in the section above)

## Checklist

- [x] ✂️ I have ensured that the PR is concise and broken down
if needed
- [x] 👀 I have read the [README](../README.md) doc
- [ ] 🧪 I have added tests that prove my fix is effective or that my
feature works
- [ ] 📚 I have added necessary documentation (if appropriate)
- [x] 🔀 Any dependent changes have been merged and published in
downstream modules

## Further comments

See #25 for more context
@gabrieleAngius gabrieleAngius mentioned this issue Jun 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabrieleAngius gabrieleAngius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabrieleAngius