Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCrshlytcs-10.24.0/upload-symbols.sh should use GoogleService-Info.plist from final package #339

Open
spelletier opened this issue Sep 5, 2024 · 2 comments

Comments

@spelletier
Copy link

For project with multiple GoogleService-Info.plist, the file used for upload-symbols.sh should be the one in the app package.

For example, in a projet with 2 app identifiers used in different build configurations, my csproj file contains these lines that select and copy the right file in the final app package.

<ItemGroup Condition="'$(Configuration)'=='Debug' Or '$(Configuration)'=='Release'">
	<BundleResource Include="GoogleService-Info-Prod.plist" LogicalName="GoogleService-Info.plist"/>

<ItemGroup Condition="'$(Configuration)'=='Debug-Test' Or '$(Configuration)'=='Release-Test'">
	<BundleResource Include="GoogleService-Info-Test.plist" LogicalName="GoogleService-Info.plist"/>

During the build in a runner, I get this error:
/Users/runner/.nuget/packages/adame.firebase.ios.crashlytics/10.24.0.2/buildTransitive/AdamE.Firebase.iOS.Crashlytics.targets(41,5): warning MSB3073: The command "'/Users/runner/Library/Caches/XamarinBuildDownload/FCrshlytcs-10.24.0/upload-symbols.sh' -gsp '/Users/runner/work/1/s/ProjectPath/GoogleService-Info.plist' -p ios '/Users/runner/work/1/s/PathToAppBundle.dSYM'" exited with code 13.

By replacing ProjectPath with PathToAppBundle, the script would always find the right file.

@AdamEssenmacher
Copy link
Collaborator

Could you open a PR at https://github.com/AdamEssenmacher/GoogleApisForiOSComponents ?

The file that would need to be modified is here: https://github.com/AdamEssenmacher/GoogleApisForiOSComponents/blob/main/source/Firebase/Analytics/Analytics.targets

You could test your changes out locally by modifying that Analytics.targets directly in your nuget cache.

@spelletier
Copy link
Author

Thank you for the hint to find out the file to change.
Pull request sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants