Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #68: Make moveArtifacts merge directories #69

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

FloezeTv
Copy link
Contributor

See #68.

I have added a dependency on fs-move. As that is implemented in JS, I added type definitions to src/custom_types.

Regarding the behavior:
moveArtifacts now merges the directories when moving.
If a file already exists in dist, it is not being overwritten. This matches the behavior I have noticed on plain astro where when a file exists in public that would be replaced by the astro-generated page (e.g., public/some_page/index.html and src/pages/some_page.astro both exist; only the generated html from src/pages/some_page.astro shows up in the final build).
I don't know if there are any other cases where a file in dist should be overwritten - this should only happen if astro generated a file at the same path as qwik does.

Would previously overwrite all contained files
@thejackshelton
Copy link
Member

Awesome job! Merging and releasing 0.5.9

@thejackshelton thejackshelton merged commit 6a81955 into QwikDev:main Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants