Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alert] [Breaking-change] create an action slot #339

Open
mattgoud opened this issue Jun 11, 2024 · 0 comments
Open

[Alert] [Breaking-change] create an action slot #339

mattgoud opened this issue Jun 11, 2024 · 0 comments
Assignees
@mattgoud
Labels
breaking change Feature Type: New Feature waiting for PM Status: Waiting for PM feedback

Comments

@mattgoud
Copy link
Collaborator

Quick description

Why this is a breaking change :

  • Given the large number of different use cases as agreed with the design, it would be desirable to integrate an action slot in which the user will be free to integrate the action elements like buttons or links (while nevertheless respecting the do/dont defined by the design)

  • remove useless props (buttonLabel, buttonWrapLabel, linkLabel)

Related discussion or PR

#246
@mattgoud mattgoud added Feature Type: New Feature breaking change labels Jun 11, 2024
@mattgoud mattgoud self-assigned this Jun 11, 2024
@mattgoud mattgoud added waiting for PM Status: Waiting for PM feedback labels Jun 12, 2024
mattgoud added a commit that referenced this issue Oct 1, 2024
@mattgoud
feat: [puik-alert] fix #339 - finally no action slot, add news option…
8a6eb5d 
…nal props instead (right/left icons and aria-label for linkButton/ActionButton), design in line with the figma model (button for the link)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattgoud mattgoud

Labels
breaking change Feature Type: New Feature waiting for PM Status: Waiting for PM feedback
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

339-alert-breaking-change-create-an-action-slot PrestaShopCorp/puik
1 participant
@mattgoud