From b1920edc7e35c0ddadb67755fd08bc1d5ad02703 Mon Sep 17 00:00:00 2001
From: Matt75 <5262628+Matt75@users.noreply.github.com>
Date: Wed, 14 Aug 2024 18:15:34 +0200
Subject: [PATCH] Fix UpdatePayPalOrderCommandHandler

---
 .../UpdatePayPalOrderCommandHandler.php              | 12 ++++++++----
 src/PayPal/Order/Exception/PayPalOrderException.php  |  4 +---
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/PayPal/Order/CommandHandler/UpdatePayPalOrderCommandHandler.php b/src/PayPal/Order/CommandHandler/UpdatePayPalOrderCommandHandler.php
index e59ad0d5c..37e9e86b6 100644
--- a/src/PayPal/Order/CommandHandler/UpdatePayPalOrderCommandHandler.php
+++ b/src/PayPal/Order/CommandHandler/UpdatePayPalOrderCommandHandler.php
@@ -89,12 +89,16 @@ public function handle(UpdatePayPalOrderCommand $command)
             $builder->buildMinimalPayload();
         }
 
-        $response = $this->httpClient->updateOrder($builder->presentPayload()->getArray());
-        $order = json_decode($response->getBody(), true);
+        $payload = $builder->presentPayload()->getArray();
+        $response = $this->httpClient->updateOrder($payload);
+
+        if ($response->getStatusCode() !== 204) {
+            throw new PayPalOrderException('Failed to update PayPal Order', PayPalOrderException::PAYPAL_ORDER_UPDATE_FAILED);
+        }
 
         $this->eventDispatcher->dispatch(new PayPalOrderUpdatedEvent(
-            $order['id'],
-            $order,
+            $command->getPayPalOrderId()->getValue(),
+            $payload,
             $command->getCartId()->getValue(),
             $command->isHostedFields(),
             $command->isExpressCheckout(),
diff --git a/src/PayPal/Order/Exception/PayPalOrderException.php b/src/PayPal/Order/Exception/PayPalOrderException.php
index b4de3faf4..949e62cb1 100644
--- a/src/PayPal/Order/Exception/PayPalOrderException.php
+++ b/src/PayPal/Order/Exception/PayPalOrderException.php
@@ -27,7 +27,5 @@ class PayPalOrderException extends PsCheckoutException
     const INVALID_ID = 1;
     const CANNOT_RETRIEVE_ORDER = 2;
     const EMPTY_ORDER_DATA = 3;
-    const CANNOT_CAPTURE_ORDER = 4;
-    const SESSION_EXCEPTION = 5;
-    const CACHE_EXCEPTION = 6;
+    const PAYPAL_ORDER_UPDATE_FAILED = 4;
 }