http: dies on platform if no credential

[josephjclark]

The http adaptor does this:

export function addBasicAuth(configuration = {}, headers) {
  const { username, password } = configuration;
  if (username && password) {
    Object.assign(headers, makeBasicAuthHeader(username, password));
  }
}

(probably other adaptors too)

This blows up on v1 if there's no credential, because v1 passesnull as the credential. And null is a value, it won't trigger the default.

While we're still supporting v1, we need to be careful about defaulting the configuration object across our adaptors.

we should really fix this in http because latest will be forever broken on v1, which isn't so good