Undo does not bring back data flows

[srcnuzn]

Describe the bug:

Have two processes connected by data flow. When deleting the process, the data flows are deleted, too. When undoing the action, only the process is brought back. The data flows are gone.

Expected behaviour:

Undo should bring back all deleted elements.

Environment:

• Version: 2.2
• Platform: Desktop App
• OS: Windows 11

To Reproduce:

1. Create two processes
2. Connect them with data flow
3. Delete one process
4. Click undo

Any additional context, screenshots, etc:

[srcnuzn]

I've almost lost a lot of my work. I accidentally deleted a process which has five data flows connected to it, each with multiple threats assigned to them. When deleting the process, all data flows and corresponding threats were gone! Fortunately, I had saved my model and I was able to reload it...

[jgadsden]

agreed, and this was a discussion in #640 that is now resolved in favour of the functionality in this bug report
we do not have a fix for this, it may be a feature of AntV/X6 that we can not get round, but planning this for version 2.4 in case it is possible

[srcnuzn]

From all the bugs I've raised yesterday, I personally think this is the most critical one, especially because identified threats/mitigations and documentations are unintentionally, but permanently lost (with no undo possibility).

By the way, the unintentional deletion happened by accidentally clicking on the delete button (I wanted to select the node)

[lreading]

I took a look at this and couldn't reproduce the issue... on linux. I was able to reproduce this on MacOS, and @srcnuzn reported this from Windows. I don't have a solution, but I just thought that was interesting and wanted to add here in case anyone picks this up. 😄

The bug might only be in electron. When using the web app on MacOS, it works as expected for me.