Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incoporate odoo-pylint conformance as always? #7

Open
blaggacao opened this issue Oct 14, 2019 · 4 comments
Open

Incoporate odoo-pylint conformance as always? #7

blaggacao opened this issue Oct 14, 2019 · 4 comments
Labels
question Further information is requested

Comments

@blaggacao
Copy link
Contributor

blaggacao commented Oct 14, 2019

As we are dealing with proper code tree transformations, it might be considerable to incorporate odoo-pylint conformance scripts in order to facilitate to move legacy code base towards an OCA compliant state.

As we have pre-commit checks in place, since v13.0.

@legalsylvain
Copy link
Collaborator

I'm in favour to remove black call and call pre-commit run -a if pre-commit is installed and pre-commit git file is present.
So, the lib will be adapted to the quality policy of the current repo.
@lmignon : what do you think ?

@legalsylvain legalsylvain added the question Further information is requested label Nov 5, 2019
@lmignon
Copy link
Sponsor Contributor

lmignon commented Nov 5, 2019

@legalsylvain 👍

@flachica
Copy link
Contributor

I have tried to implement that functionality in this PR

And in other PR I try to execute pre-commit in the code of this repository

@sbidoul
Copy link
Member

sbidoul commented Oct 1, 2020

I would personally not include a pre-commit nor black nor anything of this kind in this tool. This adds complexity and maintenance burden while imposing a specific workflow to users, and pre-commit can be combined as user wish with a couple line script or any other approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants