Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command for asking review and remove "need fixing" flag #188

Open
sebastienbeau opened this issue Jun 15, 2022 · 2 comments
Open

Add command for asking review and remove "need fixing" flag #188

sebastienbeau opened this issue Jun 15, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@sebastienbeau
Copy link
Member

Is your feature request related to a problem?
When somebody open a PR and after the review I flag it with "need fix".
I would like that this person can be able to remove this tag and flag it "need review" when it's work is ready.

Describe the solution you'd like
One possibility is to add to the bot a new command "/ocabot ask-review"
This will remove the flag "need fix" and tag it "need review"

So maintainer can focus on PR that only "need review"

Describe alternatives you've considered
giving more right on label to PR owner, but we do not want them to change all label

Additional context
I ready to contribute it, I just want to know if it's a good or bad idea or if I just do not use the right process.

Thanks for your feedback

@sbidoul @legalsylvain

@sebastienbeau sebastienbeau added the enhancement New feature or request label Jun 15, 2022
@legalsylvain
Copy link
Collaborator

Hi @sebastienbeau. At first sight, I see it as a great idea, but after consideration, I'm asking to me if it is "an OCA workflow".

See

  • OCA/web PR and filter with "changes-requested" : Result 52 PRs.
  • OCA/web PR and filter with "changes-requested" and label "need fixing" : Result 3 PRs.

Is "need fixing" label really used ? or maybe it depends on each maintainers team...

@legalsylvain
Copy link
Collaborator

@sebastienbeau : what do you think regarding my last remarks ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants