Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] add ocabot config file per repo options #108

Open
legalsylvain opened this issue Mar 28, 2020 · 3 comments
Open

[RFC] add ocabot config file per repo options #108

legalsylvain opened this issue Mar 28, 2020 · 3 comments
Labels
Bot Framework Related to the bot framework enhancement New feature or request

Comments

@legalsylvain
Copy link
Collaborator

Do you think it could be relevant to add the possibility to have custom config file in some repo, to overload some values present in the environment file. (For exemple for the value that mentions the number of APPROVALS required) that can depends on each repo policy. For exemple OpenUpgrade project has a more optimistic merging policy. (One approval required)

@sbidoul
Copy link
Member

sbidoul commented Mar 28, 2020

Could make sense, yes. That would require a significant refactoring of the configuration handling code if we want to keep it clean and manageable.

@sbidoul sbidoul added Bot Framework Related to the bot framework enhancement New feature or request labels Mar 28, 2020
@legalsylvain
Copy link
Collaborator Author

That would require a significant refactoring of the configuration handling code if we want to keep it clean and manageable.

yes, it'll take some thought.

I'll not work immediately on that feature, but we can let it opened. I think that if oca-github-bot comes with more non-consensual features like rebase command (#71 (review)), maybe it will be usefull to enable / disable for some repository there features via BOT_TASKS and BOT_TASKS_DISABLED, depending of the choice of the maintainer(s).

@sbidoul
Copy link
Member

sbidoul commented Mar 29, 2020

Agreed. Some .oca-github-bot.yml file at the repo root could override the global config options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Framework Related to the bot framework enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants