Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies without a buckaroo.toml can't be used #358

Open
rdeusser opened this issue Oct 3, 2019 · 2 comments
Open

Dependencies without a buckaroo.toml can't be used #358

rdeusser opened this issue Oct 3, 2019 · 2 comments

Comments

@rdeusser
Copy link

rdeusser commented Oct 3, 2019

Description

Adding this

[[location]]
package = "gabime/spdlog"
git = "[email protected]:gabime/spdlog"

[[dependency]]
package = "gabime/spdlog"
version = "branch=master"

to my buckaroo.toml and running buckaroo resolve ends up giving me this error: error The package gabime/spdlog at branch=master is unresolvable.

Expected Behavior

I expect that when adding a dependency that doesn't have a buckaroo.toml, it should add it anyway and let me specify the necessary rules in my BUCK file to properly build it.

Actual Behavior

I get this error: error The package gabime/spdlog at branch=master is unresolvable.`

Possible Fix

Not sure of a good way to solve this.

Steps to Reproduce

Steps in the description.

Context

Building a cpp project that relies on projects that either only build with Bazel or CMake.

Your Environment

  • Version used: 2.2.0
  • Operating System and Architecture: macOS Mojava 10.14.6 x86_64
@njlr njlr mentioned this issue Oct 3, 2019
@njlr
Copy link
Collaborator

njlr commented Oct 3, 2019

The reason that it works this way is that we don't want to resolve on versions that have not been made to work with Buckaroo. The intended usage is to add buckaroo.toml files directly to the package you want to use, or create a fork and add them there.

However, in the next version (currently being reviewed #357) we will add support for Bazel. In Bazel mode, we will be able to resolve any package that has a WORKSPACE file.

We could revisit this decision and allow packages without any metadata files to resolve, but I think it would make defining the correct version constraints more difficult.

@njlr
Copy link
Collaborator

njlr commented Oct 4, 2019

Although this issue is general, I started a port of spdlog: https://github.com/buckaroo-pm/gabime-spdlog

buckaroo add github.com/buckaroo-pm/gabime-spdlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants