Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ESM doesn't work without "type": "module" in node #3080

Open
JamesAPetts opened this issue Jun 7, 2024 · 1 comment
Open

[Bug] ESM doesn't work without "type": "module" in node #3080

JamesAPetts opened this issue Jun 7, 2024 · 1 comment
Labels
type: bug 🐞 Errors in functionality

Comments

@JamesAPetts
Copy link
Contributor

Bug description

Running vtk.js on the backend doesn't work without modifying the package.json.

(Maybe this is a feature request?)

Steps to reproduce

Try installing @kitware/vtk.js on node when using ESM. The package is incorrectly loaded, and it will run properly when "type": "module" is added.

Detailed Behavior

No response

Expected Behavior

It works OOTB in node. Is there any other issue that would be caused by adding "type": "module" to the package.json?

Environment

  • vtk.js version: master
  • node.js 18+ (but probably before also).
@JamesAPetts JamesAPetts added the type: bug 🐞 Errors in functionality label Jun 7, 2024
@daker
Copy link
Collaborator

daker commented Jun 8, 2024

What's the purpose of running it on the backend?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐞 Errors in functionality
Projects
None yet
Development

No branches or pull requests

2 participants