Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add the ability to pull version from JSON files #50

Open
6 of 12 tasks
CalvinWilkinson opened this issue Jul 21, 2022 · 0 comments
Open
6 of 12 tasks

🚧Add the ability to pull version from JSON files #50

CalvinWilkinson opened this issue Jul 21, 2022 · 0 comments
Assignees
Labels
high-priority High Priority ✨new-feature New feature that does not exist

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Jul 21, 2022

I have done the items below . . .

  • I have updated the title without removing the 🚧 emoji.

Description

Add the ability to pull versions from JSON files. This means adding another value possibility to the file-format action input.
This is going to require an implementation of the IDataParserService interface. The name of this service implementation will be JSONParserService.

Also, remove the CSharpProjFileService and CSharpProjFileServiceTests classes. These are not being used by anything.
Create a new factory to generate XMLParserService and JSONParserService service classes, and inject the factory into the GitHubAction class for use.

Acceptance Criteria

This issue is finished when:

  • CSharpProjFileService class removed
  • CSharpProjFileServiceTests class removed
  • Service factory created
  • Unit tests added
  • All unit tests pass

ToDo Items

  • Priority label added to this issue. Refer to the Priority Type Labels section below.
  • Change type labels added to this issue. Refer to the Change Type Labels section below.
  • Issue linked to the correct project.
  • Issue linked to the correct milestone.
  • Draft pull request created and linked to this issue.

Issue Dependencies

No response

Related Work

No response

Additional Information:

Change Type Labels

Change Type Label
Bug Fixes 🐛bug Something isn't working
Breaking Changes https://github.com/KinsonDigital/VersionMiner/labels/%F0%9F%A7%A8breaking%20changes
Enhancement https://github.com/KinsonDigital/VersionMiner/labels/enhancement
Workflow Changes https://github.com/KinsonDigital/VersionMiner/labels/workflow
Code Doc Changes https://github.com/KinsonDigital/VersionMiner/labels/%F0%9F%93%91documentation%2Fcode
Product Doc Changes https://github.com/KinsonDigital/VersionMiner/labels/%F0%9F%93%9Ddocumentation%2Fproduct

Priority Type Labels

Priority Type Label
Low Priority https://github.com/KinsonDigital/VersionMiner/labels/low%20priority
Medium Priority https://github.com/KinsonDigital/VersionMiner/labels/medium%20priority
High Priority https://github.com/KinsonDigital/VersionMiner/labels/high%20priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added ✨new-feature New feature that does not exist high-priority High Priority labels Jul 21, 2022
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0 milestone Jul 21, 2022
@CalvinWilkinson CalvinWilkinson self-assigned this Aug 18, 2022
@CalvinWilkinson CalvinWilkinson modified the milestones: v1.0.0-preview.5, v1.0.0.preview.6, v1.0.0-preview.6 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high-priority High Priority ✨new-feature New feature that does not exist
Projects
Status: ⚪Not Set
Development

No branches or pull requests

2 participants