-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tap: allow sharding of fonts in Homebrew/cask #17239
Conversation
Signed-off-by: Patrick Linnane <[email protected]> Co-authored-by: Carlo Cabrera <[email protected]> Co-authored-by: Mike McQuaid <[email protected]>
Throwing a comment here to poll the group. I made similar changes that is more code, but don't need to rename Casks. Not sure I like it though. Effectively a new def in
Then in
If there's a better way I could've shared these changes please let me know! I didn't want to open a competing PR and I didn't want to clobber the existing PR. |
@krehel Can you benchmark your proposal? Want to see how it affects performance. |
I did locally with Edit, fwiw: My changes:
This PR:
|
@carlocab @MikeMcQuaid If you can weigh in on the above it would be appreciated. I want to make sure we're using the right approach here. |
Indeed. Feel free to tell me it's terrible or not 😄 (also: I am genuinely curious which is preferred) |
As I said in Homebrew/homebrew-cask#173366 (comment), I'm against disallowing normal casks to start with |
Sounds good. @krehel I'm going to close this and the cask PR. Can you open a PR with your proposed change? Thanks! |
@p-linnane will do. Thanks |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?We want to migrate Homebrew/cask-fonts into the main Homebrew/cask repo. There are ~2,200 font casks that need to be put into sharded subdirectories. This PR allows for paths such as
Casks/fonts/font-a/font-apple.rb
.