Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current rate limiting is not effective in non KRB environments #323

Open
flaming-archer opened this issue Jul 4, 2024 · 1 comment

Comments

@flaming-archer
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. For example - I'm always frustrated when [...]
The current rate limiting has been introduced from #314.
But when we tested it, we found that it didn't work in krb environment.

Describe the solution you'd like
According to the log, users are all empty, as follows .
08:36:28.243 [pool-6-thread-198] INFO com.hotels.bdp.waggledance.server.ExceptionWrappingHMSHandler - WD Audit:[User:, method:shutdown, args:null]
08:37:15.882 [pool-6-thread-143] INFO com.hotels.bdp.waggledance.server.ExceptionWrappingHMSHandler - WD Audit:[User:, method:getThreadId, args:null]
08:37:15.883 [pool-6-thread-143] INFO com.hotels.bdp.waggledance.server.ExceptionWrappingHMSHandler - WD Audit:[User:, method:get_current_notificationEventId, args:null]

After investigation, we found that the current limiting depends on ugi, and the ugi of WD comes from calling the set_ugi method. The call to set_ugi comes from the client of WD. But this client call can only be called in non secure mode (non KRB).

The following code in class HiveMetaStoreClient.java can illustrate :
WechatIMG2289

Describe alternatives you've considered
Perhaps we need to set up ugi in the KRB environmen.

Additional context
For now, we don't need the current limiting. Perhaps I will implement it when needed in the future.

@flaming-archer
Copy link
Contributor Author

Let me first create a missing feature here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant