Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface_fraction error with 2 GPUs #687

Open
juliasloan25 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #863
Open

surface_fraction error with 2 GPUs #687

juliasloan25 opened this issue Mar 12, 2024 · 2 comments · May be fixed by #863
Assignees
Labels
bug Something isn't working GPU

Comments

@juliasloan25
Copy link
Member

juliasloan25 commented Mar 12, 2024

When we run simulations on 2 GPUs, we get an error that the surface fractions don't sum up to 1. This doesn't happen when running on 1 or 4 GPUs. See examples on buildkite here or here. Seen both when run on buildkite and when run via slurm directly on clima

stacktrace:

ERROR: LoadError: AssertionError: minimum((cs.surface_fractions.ice .+ cs.surface_fractions.land) .+ cs.surface_fractions.ocean) ≈ FT(1)
--
  | Stacktrace:
  | [1] update_surface_fractions!(cs::CoupledSimulation{…})
  | @ ClimaCoupler.Regridder /scratch/clima/slurm-buildkite/climacoupler-target-gpu-simulations/44/climacoupler-target-gpu-simulations/src/Regridder.jl:513
  | [2] top-level scope
  | @ /scratch/clima/slurm-buildkite/climacoupler-target-gpu-simulations/44/climacoupler-target-gpu-simulations/experiments/AMIP/coupler_driver.jl:559
  | in expression starting at /scratch/clima/slurm-buildkite/climacoupler-target-gpu-simulations/44/climacoupler-target-gpu-simulations/experiments/AMIP/coupler_driver.jl:559

when run interactively, we see that minimum((cs.surface_fractions.ice .+ cs.surface_fractions.land) .+ cs.surface_fractions.ocean) == 0. We expect this sum to always be exactly 1 at each point on the sphere.

@juliasloan25 juliasloan25 added bug Something isn't working GPU labels Mar 12, 2024
@juliasloan25
Copy link
Member Author

it seems like this is related to CliMA/ClimaAtmos.jl#2993

@juliasloan25
Copy link
Member Author

consider #807 - for a coupler solution we could consider using the get_field methods, if we test them and see that this issue doesn't arise using those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GPU
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant