Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include super.method() call in an auto-generated override method #641

Open
ylazy opened this issue Nov 6, 2022 · 3 comments
Open

Include super.method() call in an auto-generated override method #641

ylazy opened this issue Nov 6, 2022 · 3 comments

Comments

@ylazy
Copy link

ylazy commented Nov 6, 2022

The current override code:

override protected function foo():void

The expected code:

override protected function foo():void
{
    super.foo();
}
@joshtynjala joshtynjala changed the title an auto-generated override method should have super.method() Include super.method() call in an auto-generated override method Nov 7, 2022
@joshtynjala
Copy link
Member

I'm going to mark this won't fix. An override isn't required to call super, so I don't think it makes sense to always include it.

@ylazy
Copy link
Author

ylazy commented Dec 8, 2022

Could you create an extension setting to change this default behavior?
Flash Develop includes super.method() by default and this's very useful for me because sometimes I forget to include it, and this leads to unexpected errors that are hard to debug. For me, almost cases I need it by default, and I can easily remove it if I don't need.

@joshtynjala
Copy link
Member

I'll consider it for a future update.

@joshtynjala joshtynjala reopened this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants