Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeGLUT 3.2.1 changes break linking of Display/register #134

Open
gdevenyi opened this issue Feb 23, 2021 · 9 comments
Open

FreeGLUT 3.2.1 changes break linking of Display/register #134

gdevenyi opened this issue Feb 23, 2021 · 9 comments

Comments

@gdevenyi
Copy link
Contributor

Display and register don't have -lXxf86vm in their link list and fail to link. Adding them manually to link.txt allows the build to finish.

I'm not exactly sure the right place to add these, or if its a freeglut bug.

@vfonov
Copy link
Member

vfonov commented Feb 23, 2021

on Ubuntu 20.04 Display and Register do not seem to link to it. Which os are you using?

@gdevenyi
Copy link
Contributor Author

This is on niagara.computecanada.ca, with either Centos7 or RHEL7.

@vfonov
Copy link
Member

vfonov commented Feb 23, 2021

could it be that freeglut's cmake build found this library and is linking to it, but only if the -dev version is present on the system? (I don't have it)

@gdevenyi
Copy link
Contributor Author

It may be some unwanted cleverness in cmake. Given the freeglut change, can the Display/register linking inherit the proper linker settings from the FreeGLUT cmake?

In 18.04 with earlier FreeGLUT it doesn't seem to have linked against it on my system even though I have it.

@vfonov
Copy link
Member

vfonov commented Feb 23, 2021

i will try

@vfonov
Copy link
Member

vfonov commented Feb 23, 2021

my original transfer to the new FreeGLUT was to see if it works better with HiDPI displays , it doesn't seem to. Any ideas?

@gdevenyi
Copy link
Contributor Author

Based on my reading of:
http://freeglut.sourceforge.net/progress.php
https://sourceforge.net/p/freeglut/mailman/message/30859054/
and
https://github.com/dcnieho/FreeGLUT/tree/feature_DPI_awareness

Very basic patches were proposed and not yet merged.
Trying out the patch appears to require patching our freeglut initialization as well: freeglut/freeglut@60272c9#diff-33fb9745ffcac6feed42503555088755b013c1c26055303ebaecbbda0b608917R243

@vfonov
Copy link
Member

vfonov commented Feb 24, 2021

"If true, on window the application will be declared DPI aware. No effect on other platoforms"

@gdevenyi
Copy link
Contributor Author

Sounds like its very very basic :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants