Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop isRecording() from core-tracing #31206

Open
6 tasks
howieleung opened this issue Sep 24, 2024 · 0 comments
Open
6 tasks

Drop isRecording() from core-tracing #31206

howieleung opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.

Comments

@howieleung
Copy link
Contributor

  • Package Name: core-tracing
  • Package Version:
  • Operating system:
  • nodejs
    • version:
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
A clear and concise description of what the bug is.
Check this comment:
#31160 (comment)

With the current code of otel, there is no reason to check isRecording() and avoid setting attributes, event, status if it is false. It is because otel is checking isEnded inside of these functions and do nothing.

To Reproduce
Steps to reproduce the behavior:
1.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 24, 2024
@howieleung howieleung mentioned this issue Sep 24, 2024
3 tasks
@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Sep 25, 2024
@github-actions github-actions bot removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

No branches or pull requests

3 participants