From fe66a1202fe8e93ceca7546881bcef539f9a6130 Mon Sep 17 00:00:00 2001 From: namnguyen Date: Mon, 23 Sep 2024 15:04:52 +0700 Subject: [PATCH 1/5] docs --- taipy/gui/extension/library.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/taipy/gui/extension/library.py b/taipy/gui/extension/library.py index 72a8ac814c..5d175e5666 100644 --- a/taipy/gui/extension/library.py +++ b/taipy/gui/extension/library.py @@ -113,7 +113,7 @@ def __init__( Arguments: default_property (str): the name of the default property for this element. - properties (List[ElementProperty]): The list of properties for this element. + properties (Dict[ElementProperty]): The dictionary of properties for this element. inner_properties (Optional[List[ElementProperty]]): The optional list of inner properties for this element.
Default values are set/binded automatically. react_component (Optional[str]): The name of the component to be created on the front-end.
From 6d3693aacf34c6036ec753446ae1b5c48eaa8048 Mon Sep 17 00:00:00 2001 From: namnguyen Date: Thu, 3 Oct 2024 11:27:02 +0700 Subject: [PATCH 2/5] Adding key - value to properties in Element definition --- taipy/gui/extension/library.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/taipy/gui/extension/library.py b/taipy/gui/extension/library.py index 5d175e5666..1f8b44297b 100644 --- a/taipy/gui/extension/library.py +++ b/taipy/gui/extension/library.py @@ -112,8 +112,8 @@ def __init__( *react_component* is ignored. Arguments: - default_property (str): the name of the default property for this element. - properties (Dict[ElementProperty]): The dictionary of properties for this element. + default_property (str): The name of the default property for this element. + properties (Dict[ElementProperty]): The dictionary containing the properties of this element, where the keys are the property names and the values are instances of ElementProperty. inner_properties (Optional[List[ElementProperty]]): The optional list of inner properties for this element.
Default values are set/binded automatically. react_component (Optional[str]): The name of the component to be created on the front-end.
From a38192ccfc723b792532698d6f074393cbfe3233 Mon Sep 17 00:00:00 2001 From: namnguyen Date: Thu, 3 Oct 2024 22:52:09 +0700 Subject: [PATCH 3/5] per Fred --- taipy/gui/extension/library.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/taipy/gui/extension/library.py b/taipy/gui/extension/library.py index 1f8b44297b..27c16021c3 100644 --- a/taipy/gui/extension/library.py +++ b/taipy/gui/extension/library.py @@ -113,7 +113,7 @@ def __init__( Arguments: default_property (str): The name of the default property for this element. - properties (Dict[ElementProperty]): The dictionary containing the properties of this element, where the keys are the property names and the values are instances of ElementProperty. + properties (Dict[str, ElementProperty]): The dictionary containing the properties of this element, where the keys are the property names and the values are instances of ElementProperty. inner_properties (Optional[List[ElementProperty]]): The optional list of inner properties for this element.
Default values are set/binded automatically. react_component (Optional[str]): The name of the component to be created on the front-end.
From b4959870803db9e0feb1b16a6b02fde165457934 Mon Sep 17 00:00:00 2001 From: Deepanshu <110890939+DeepanshuProgrammer@users.noreply.github.com> Date: Fri, 4 Oct 2024 01:16:49 +0530 Subject: [PATCH 4/5] Update contributors.txt (#1901) Added my username as a contributor to the repo --- contributors.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/contributors.txt b/contributors.txt index a291359218..d4a58ca288 100644 --- a/contributors.txt +++ b/contributors.txt @@ -17,3 +17,4 @@ yarikoptic Luke-0162 Satoshi-Sh kushal34712 +DeepanshuProgrammer From 33441dd5d2879f6e5507489cb0d28b88b981be42 Mon Sep 17 00:00:00 2001 From: Ikko Eltociear Ashimine Date: Fri, 4 Oct 2024 04:54:17 +0900 Subject: [PATCH 5/5] chore: update test_dispatcher__execute_job.py (#1900) disptach -> dispatch --- .../_orchestrator/_dispatcher/test_dispatcher__execute_job.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/core/_orchestrator/_dispatcher/test_dispatcher__execute_job.py b/tests/core/_orchestrator/_dispatcher/test_dispatcher__execute_job.py index e9a80b9b17..fd222f2624 100644 --- a/tests/core/_orchestrator/_dispatcher/test_dispatcher__execute_job.py +++ b/tests/core/_orchestrator/_dispatcher/test_dispatcher__execute_job.py @@ -48,7 +48,7 @@ def test_execute_job(): mck_2.assert_called_once_with(job.task) # This should be called to check if job needs to run mck_1.assert_called_once_with(job) assert job.is_running() # The job is not executed since the dispatch is mocked - assert scenario.dn.edit_in_progress # outputs must NOT have been unlocked because the disptach is mocked + assert scenario.dn.edit_in_progress # outputs must NOT have been unlocked because the dispatch is mocked def test_execute_job_to_skip(): @@ -85,7 +85,7 @@ def test_execute_job_skippable_with_force(): mck_1.assert_called_once_with(job) # This should be called to dispatch the job mck_2.assert_not_called() # This should NOT be called since we force the execution anyway assert job.is_running() # The job is not executed since the dispatch is mocked - assert scenario.dn.edit_in_progress # outputs must NOT have been unlocked because the disptach is mocked + assert scenario.dn.edit_in_progress # outputs must NOT have been unlocked because the dispatch is mocked def test_execute_jobs_synchronously():