Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMR.load and AMR.amr_to_string changes data during read in test/amr_examples #25

Open
quffaro opened this issue Oct 31, 2023 · 1 comment
Assignees

Comments

@quffaro
Copy link
Member

quffaro commented Oct 31, 2023

amr_to_string appears to change data as its being read. This means that a test case (AMR.amr_to_string(AMR.load(ASKEModel, model_expr))) == modelrep will always fail. Here are two concrete observations of this issue:

  1. "@" character is omitted on AMR.load
    Expected Call the argument of amr_to_string in the test case M. A substring of M.header should read:
    "...ASKE Model Representation: SIR [email protected]..."
    Observed The substring of M.header omits the "@" character:
    "...ASKE Model Representation: SIR Model0.1..."
  2. A match case in amr_to_string erroneously interprets ODERecord as ODEList
    Expected The ODERecord is interpreted by the ODERecord match case and return "ODE_Record = ..."
    Observed The relevant substring in the output of amr_to_string has "ODE Equations" instead.
@lukem12345
Copy link
Member

@quffaro Can you upload these examples as tests to some branch in this repo?

@quffaro quffaro self-assigned this Feb 6, 2024
jpfairbanks added a commit that referenced this issue Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants