Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth_subscribe method not found #866

Open
ermalkaleci opened this issue Oct 19, 2023 · 1 comment
Open

eth_subscribe method not found #866

ermalkaleci opened this issue Oct 19, 2023 · 1 comment

Comments

@ermalkaleci
Copy link
Contributor

AcalaNetwork/subway#119

Bodhi will return invalid params, maybe we need to make it return method not found like eth

@shunjizhan
Copy link
Collaborator

shunjizhan commented Oct 20, 2023

input

{
    "jsonrpc":"2.0","id": 2,
    "method": "eth_subscribe",
    "params": ["nonono"]
}

current output

{
    "id": 2,
    "jsonrpc": "2.0",
    "error": {
        "code": -32602,
        "message": "invalid argument 0: expected eventName `newHeads`, `newFinalizedHeads` or `logs`"
    }
}

expected output

{
    "jsonrpc": "2.0",
    "error": {
        "code": -32601,
        "message": "no \"nonono\" subscription in eth namespace"
    },
    "id": 2
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants