Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify & upstream our code for profile_list differentiation #4021

Open
8 tasks
yuvipanda opened this issue May 2, 2024 · 0 comments
Open
8 tasks

Unify & upstream our code for profile_list differentiation #4021

yuvipanda opened this issue May 2, 2024 · 0 comments

Comments

@yuvipanda
Copy link
Member

yuvipanda commented May 2, 2024

We currently have code that allows us to show people different profile list options based on some notion of group membership. The initial implementation was tied to GitHub teams membership, and hence not upstreamable into KubeSpawner (where the profile_list code lives). However, with #3883, we have a version of that code that uses JupyterHub groups, and hence is now actually upstreamable.

Unifying this code and upstreaming it allows us to maintain fewer things. There's no real rush, but it's useful to make sure that whatever we do is done with an eye to upstreaming. To that end, I've already been slowly working on things that can help make this happen. Here's a linear set of items that we can do to help.

The timeline for this is 'slowly, over months'.

yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue May 2, 2024
This gets rid of restricting profile options based on github *org*
membership, rather than *teams* membership. This is a complete no-op
for any of our communities, as it turns out nobody is using this feature!
Getting rid of this makes sure that new communities will not use this
feature, as it relies on internal implementation details of the
GitHub authenticator and may be hard to upstream when the time
comes. See 2i2c-org#4021
for upstreaming plan.
yuvipanda added a commit to yuvipanda/pilot-hubs that referenced this issue May 7, 2024
This gets rid of restricting profile options based on github *org*
membership, rather than *teams* membership. This is a complete no-op
for any of our communities, as it turns out nobody is using this feature!
Getting rid of this makes sure that new communities will not use this
feature, as it relies on internal implementation details of the
GitHub authenticator and may be hard to upstream when the time
comes. See 2i2c-org#4021
for upstreaming plan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant